| Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 1 | = Review UI |
| 2 | |
| 3 | Reviewing changes is an important task and the Gerrit Web UI provides |
| 4 | many functionalities to make the review process comfortable and |
| 5 | efficient. This is a guide through the review UI that explains the |
| 6 | different functions and UI elements. |
| 7 | |
| 8 | [[change-screen]] |
| 9 | == Change Screen |
| 10 | |
| 11 | The change screen shows the details of a single change and provides |
| 12 | various actions on it. |
| 13 | |
| 14 | image::images/user-review-ui-change-screen.png[width=800, link="images/user-review-ui-change-screen.png"] |
| 15 | |
| 16 | [[commit-message]] |
| 17 | === Commit Message Block |
| 18 | |
| 19 | The focus of the change screen is on the commit message since this is |
| 20 | the most important information about a change. The numeric change ID |
| 21 | and the change status are displayed right above the commit message. |
| 22 | |
| 23 | image::images/user-review-ui-change-screen-commit-message.png[width=800, link="images/user-review-ui-change-screen-commit-message.png"] |
| 24 | |
| 25 | The commit message can be edited directly in the Web UI by clicking on |
| 26 | the `Edit Message` button in the change header. This opens a drop-down |
| 27 | editor box in which the commit message can be edited. Saving |
| 28 | modifications of the commit message automatically creates a new patch |
| 29 | set for the change. The commit message may only be edited on the |
| 30 | current patch set. |
| 31 | |
| 32 | image::images/user-review-ui-change-screen-edit-commit-message.png[width=800, link="images/user-review-ui-change-screen-edit-commit-message.png"] |
| 33 | |
| 34 | The numeric change ID is a link to the change and clicking on it |
| 35 | refreshes the change screen. By copying the link location you can get |
| 36 | the permalink of the change. |
| 37 | |
| 38 | image::images/user-review-ui-change-screen-permalink.png[width=800, link="images/user-review-ui-change-screen-permalink.png"] |
| 39 | |
| 40 | The change status shows the state of the change: |
| 41 | |
| 42 | - `Needs <label>`: |
| 43 | + |
| 44 | The change is in review and an approval on the shown label is still |
| 45 | required to make the change submittable. |
| 46 | |
| 47 | - `Not <label>`: |
| 48 | + |
| 49 | The change is in review and a veto vote on the shown label is |
| 50 | preventing the submit. |
| 51 | |
| Edwin Kempin | b2a8ae3 | 2014-05-02 15:03:22 +0200 | [diff] [blame^] | 52 | [[not-current]] |
| Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 53 | - `Not Current`: |
| 54 | + |
| 55 | The currently viewed patch set is outdated. |
| 56 | + |
| 57 | Please note that some operations, like voting, are not available on |
| 58 | outdated patch sets, but only on the current patch set. |
| 59 | |
| 60 | - `Ready to Submit`: |
| 61 | + |
| 62 | The change has all necessary approvals and may be submitted. |
| 63 | |
| 64 | - `Submitted, Merge Pending`: |
| 65 | + |
| 66 | The change was submitted and was added to the merge queue. |
| 67 | + |
| 68 | The change stays in the merge queue if it depends on a change that is |
| 69 | still in review. In this case it will get automatically merged when all |
| 70 | predecessor changes have been merged. |
| 71 | + |
| 72 | This status can also mean that the change depends on an abandoned |
| 73 | change or on an outdated patch set of another change. In this case you |
| 74 | may want to rebase the change. |
| 75 | |
| 76 | - `Merged`: |
| 77 | + |
| 78 | The change was successfully merged into the destination branch. |
| 79 | |
| 80 | - `Abandoned`: |
| 81 | + |
| 82 | The change was abandoned. |
| 83 | |
| 84 | - `Draft`: |
| 85 | + |
| 86 | The change is a draft that is only visible to the change owner, the |
| 87 | reviewers that were explicitly added to the change, and users who have |
| 88 | the link:access-control.html#category_view_drafts[View Drafts] global |
| 89 | capability assigned. |
| 90 | |
| 91 | [[commit-info]] |
| 92 | === Commit Info Block |
| 93 | |
| 94 | The commit info block shows information about the commit of the |
| 95 | currently viewed patch set. |
| 96 | |
| 97 | It displays the author and the committer as links to a list of this |
| 98 | person's changes that have the same status as the currently viewed |
| 99 | change. |
| 100 | |
| 101 | The commit ID and the link:user-changeid.html[Change-Id] are both |
| 102 | displayed with a copy-to-clipboard icon that allows the ID to be copied |
| 103 | into the clipboard. |
| 104 | |
| 105 | If a Git web browser, such as GitWeb or Gitiles, is configured, there |
| 106 | is also a link to the commit in the Git web browser. |
| 107 | |
| 108 | image::images/user-review-ui-change-screen-commit-info.png[width=800, link="images/user-review-ui-change-screen-commit-info.png"] |
| 109 | |
| Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 110 | [[change-info]] |
| 111 | === Change Info Block |
| 112 | |
| 113 | The change info block contains detailed information about the change |
| 114 | and offers actions on the change. |
| 115 | |
| 116 | image::images/user-review-ui-change-screen-change-info.png[width=800, link="images/user-review-ui-change-screen-change-info.png"] |
| 117 | |
| 118 | - Change Owner: |
| 119 | + |
| 120 | The owner of the change is displayed as a link to a list of the owner's |
| 121 | changes that have the same status as the currently viewed change. |
| 122 | + |
| 123 | image::images/user-review-ui-change-screen-change-info-owner.png[width=800, link="images/user-review-ui-change-screen-change-info-owner.png"] |
| 124 | |
| 125 | - Reviewers: |
| 126 | + |
| 127 | The reviewers of the change are displayed as chip tokens. |
| 128 | + |
| 129 | For each reviewer there is a tooltip that shows on which labels the |
| 130 | reviewer is allowed to vote. |
| 131 | + |
| 132 | New reviewers can be added by clicking on the `Add...` button. Typing |
| 133 | into the pop-up text field activates auto completion of user and group |
| 134 | names. |
| 135 | + |
| 136 | Reviewers can be removed from the change by clicking on the `x` icon |
| 137 | in the reviewer's chip token. Removing a reviewer also removes the |
| 138 | current votes of the reviewer. The removal of votes is recorded as a |
| 139 | message on the change. |
| 140 | + |
| 141 | Removing reviewers is protected by permissions: |
| 142 | |
| 143 | ** Users can always remove themselves. |
| 144 | ** The change owner may remove any zero or positive score. |
| 145 | ** Users with the link:access-control.html#category_remove_reviewer[ |
| 146 | Remove Reviewer] access right, the branch owner, the project owner |
| 147 | and Gerrit administrators may remove anyone. |
| 148 | |
| 149 | + |
| 150 | image::images/user-review-ui-change-screen-change-info-reviewers.png[width=800, link="images/user-review-ui-change-screen-change-info-reviewers.png"] |
| 151 | |
| 152 | - Project / Branch / Topic: |
| 153 | + |
| 154 | The name of the project for which the change was done is displayed as a |
| 155 | link to the link:user-dashboards.html#project-default-dashboard[default |
| 156 | dashboard] of the project. If no default dashboard is defined, the link |
| 157 | opens a list of open changes on the project. |
| 158 | + |
| 159 | Clicking on the settings icon on the right side navigates to the |
| 160 | project administration screen. |
| 161 | + |
| 162 | The name of the destination branch is displayed as a link to a list |
| 163 | with all changes on this branch that have the same status as the |
| 164 | currently viewed change. |
| 165 | + |
| 166 | If a topic was assigned to the change it is displayed below the branch. |
| 167 | By clicking on the edit icon the topic can be set. This requires the |
| 168 | link:access-control.html#category_edit_topic_name[Edit Topic Name] |
| 169 | access right. To be able to set a topic on a closed change, the |
| 170 | `Edit Topic Name` must be assigned with the `force` flag. |
| 171 | + |
| 172 | image::images/user-review-ui-change-screen-change-info-project-branch-topic.png[width=800, link="images/user-review-ui-change-screen-change-info-project-branch-topic.png"] |
| 173 | |
| 174 | - Submit Strategy: |
| 175 | + |
| 176 | The link:project-setup.html#submit_type[submit strategy] that will be |
| 177 | used to submit the change. The submit strategy is only displayed for |
| 178 | open changes. |
| 179 | + |
| 180 | image::images/user-review-ui-change-screen-change-info-submit-strategy.png[width=800, link="images/user-review-ui-change-screen-change-info-submit-strategy.png"] |
| 181 | + |
| 182 | If a change cannot be merged due to path conflicts this is highlighted |
| 183 | by a bold red `Cannot Merge` label. |
| 184 | + |
| 185 | image::images/user-review-ui-change-screen-change-info-cannot-merge.png[width=800, link="images/user-review-ui-change-screen-change-info-cannot-merge.png"] |
| 186 | |
| 187 | - Time of Last Update: |
| 188 | + |
| 189 | image::images/user-review-ui-change-screen-change-info-last-update.png[width=800, link="images/user-review-ui-change-screen-change-info-last-update.png"] |
| 190 | |
| 191 | - Actions: |
| 192 | + |
| 193 | Depending on the change state and the permissions of the user, different |
| 194 | actions are available on the change: |
| 195 | |
| 196 | ** `Merge Change`: |
| 197 | + |
| 198 | Submits the change and adds it to the merge queue. If possible the |
| 199 | change is merged into the destination branch. |
| 200 | + |
| 201 | The `Merge Change` button is available if the change is submittable and |
| 202 | the link:access-control.html#category_submit[Submit] access right is |
| 203 | assigned. |
| 204 | + |
| 205 | It is also possible to submit changes that have merge conflicts. This |
| 206 | allows to do the conflict resolution for a change series in a single |
| 207 | merge commit and submit the changes in reverse order. |
| 208 | |
| 209 | ** `Abandon`: |
| 210 | + |
| 211 | Abandons the change. |
| 212 | + |
| 213 | The `Abandon` button is only available if the change is open and the |
| 214 | link:access-control.html#category_abandon[Abandon] access right is |
| 215 | assigned. |
| 216 | + |
| 217 | When a change is abandoned, a panel appears that allows one to type a |
| 218 | comment message to explain why the change is being abandoned. |
| 219 | |
| 220 | ** `Restore`: |
| 221 | + |
| 222 | Restores the change. |
| 223 | + |
| 224 | The `Restore` button is only available if the change is abandoned and |
| 225 | the link:access-control.html#category_abandon[Abandon] and the |
| 226 | link:access-control.html#category_push[Push] access right is |
| 227 | assigned. |
| 228 | + |
| 229 | When a change is restored, a panel appears that allows one to type a |
| 230 | comment message to explain why the change is being restored. |
| 231 | |
| 232 | ** `Rebase`: |
| 233 | + |
| 234 | Rebases the change. The rebase is always done with content merge |
| 235 | enabled. If the rebase is successful a new patch set with the rebased |
| 236 | commit is created. If the rebase fails, there are conflicts that have |
| 237 | to be resolved manually. |
| 238 | + |
| 239 | If the change does not depend on another open change, it is rebased |
| 240 | onto the tip of the destination branch. |
| 241 | + |
| 242 | If the change depends on another open change, it is rebased onto the |
| 243 | current patch set of that other change. |
| 244 | + |
| 245 | The `Rebase` button is only available if the change can be rebased and |
| 246 | the link:access-control.html#category_rebase[Rebase] access right is |
| 247 | assigned. Rebasing merge commits is not supported. |
| 248 | |
| 249 | ** `Cherry-Pick`: |
| 250 | + |
| 251 | Allows to cherry-pick the change to another branch. The destination |
| 252 | branch can be selected from a dialog. Cherry-picking a change creates a |
| 253 | new open change on the selected destination branch. |
| 254 | + |
| 255 | It is also possible to cherry-pick a change to the same branch. This is |
| 256 | effectively the same as rebasing it to the current tip of the |
| 257 | destination branch. This can be used to remove dependencies on other |
| 258 | open changes. |
| 259 | + |
| 260 | Users can only cherry-pick changes to branches for which they are |
| 261 | allowed to upload changes for review. |
| 262 | |
| 263 | ** `Publish`: |
| 264 | + |
| 265 | Publishes the currently viewed draft patch set. If this is the first |
| 266 | patch set of a change that is published, the change will be published |
| 267 | as well. |
| 268 | + |
| 269 | The `Publish` button is only available if a draft patch set is viewed |
| 270 | and the user is the change owner or has the |
| 271 | link:access-control.html#category_publish_drafts[Publish Drafts] access |
| 272 | right assigned. |
| 273 | |
| 274 | ** `Delete Change` / `Delete Revision`: |
| 275 | + |
| 276 | Deletes the draft change / the currently viewed draft patch set. |
| 277 | + |
| 278 | The `Delete Change` / `Delete Revision` buttons are only available if a |
| 279 | draft patch set is viewed and the user is the change owner or has the |
| 280 | link:access-control.html#category_delete_drafts[Delete Drafts] access |
| 281 | right assigned. |
| 282 | |
| 283 | ** Further actions may be available if plugins are installed. |
| 284 | |
| 285 | + |
| 286 | image::images/user-review-ui-change-screen-change-info-actions.png[width=800, link="images/user-review-ui-change-screen-change-info-actions.png"] |
| 287 | |
| 288 | - Labels & Votes: |
| 289 | + |
| 290 | Approving votes are colored green; veto votes are colored red. |
| 291 | + |
| 292 | image::images/user-review-ui-change-screen-change-info-labels.png[width=800, link="images/user-review-ui-change-screen-change-info-labels.png"] |
| 293 | |
| Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 294 | [[files]] |
| 295 | === File List |
| 296 | |
| 297 | The file list shows the files that are modified in the currently viewed |
| 298 | patch set. |
| 299 | |
| 300 | image::images/user-review-ui-change-screen-file-list.png[width=800, link="images/user-review-ui-change-screen-file-list.png"] |
| 301 | |
| 302 | The checkboxes in front of the file names allow files to be marked as reviewed. |
| 303 | |
| 304 | image::images/user-review-ui-change-screen-file-list-mark-as-reviewed.png[width=800, link="images/user-review-ui-change-screen-file-list-mark-as-reviewed.png"] |
| 305 | |
| 306 | The type of a file modification is indicated by the character in front |
| 307 | of the file name: |
| 308 | |
| 309 | - 'no character' (Modified): |
| 310 | + |
| 311 | The file existed before this change and is modified. |
| 312 | |
| 313 | - `A` (Added): |
| 314 | + |
| 315 | The file is newly added. |
| 316 | |
| 317 | - `D` (Deleted): |
| 318 | + |
| 319 | The file is deleted. |
| 320 | |
| 321 | - `R` (Renamed): |
| 322 | + |
| 323 | The file is renamed. |
| 324 | |
| 325 | - `C` (Copied): |
| 326 | + |
| 327 | The file is new and is copied from an existing file. |
| 328 | |
| 329 | image::images/user-review-ui-change-screen-file-list-modification-type.png[width=800, link="images/user-review-ui-change-screen-file-list-modification-type.png"] |
| 330 | |
| 331 | If a file is renamed or copied, the name of the original file is |
| 332 | displayed in gray below the file name. |
| 333 | |
| 334 | image::images/user-review-ui-change-screen-file-list-rename.png[width=800, link="images/user-review-ui-change-screen-file-list-rename.png"] |
| 335 | |
| 336 | Repeating path segments are grayed out. |
| 337 | |
| 338 | image::images/user-review-ui-change-screen-file-list-repeating-paths.png[width=800, link="images/user-review-ui-change-screen-file-list-repeating-paths.png"] |
| 339 | |
| 340 | Inline comments on a file are shown in the `Comments` column. |
| 341 | |
| 342 | Draft comments, i.e. comments that have been written by the current |
| 343 | user but not yet published, are highlighted in red. |
| 344 | |
| 345 | New comments from other users, that were published after the current |
| 346 | user last reviewed this change, are highlighted in bold. |
| 347 | |
| 348 | image::images/user-review-ui-change-screen-file-list-comments.png[width=800, link="images/user-review-ui-change-screen-file-list-comments.png"] |
| 349 | |
| 350 | The size of the modifications in the files can be seen in the `Size` |
| 351 | column. The footer row shows the total size of the change. |
| 352 | |
| 353 | For files, the `Size` column shows the sum of inserted and deleted |
| 354 | lines as one number. For the total size, inserted and deleted lines are |
| 355 | shown separately. In addition, the number of insertions and deletions |
| 356 | is shown as a bar. The size of the bar indicates the amount of changed |
| 357 | lines, and its coloring in green and red shows the proportion of |
| 358 | insertions to deletions. |
| 359 | |
| 360 | The size information is useful to easily spot the files that contain |
| 361 | the most modifications; these files are likely to be the most relevant |
| 362 | files for this change. The total change size gives an estimate of how |
| 363 | long a review of this change may take. |
| 364 | |
| 365 | image::images/user-review-ui-change-screen-file-list-size.png[width=800, link="images/user-review-ui-change-screen-file-list-size.png"] |
| 366 | |
| 367 | In the header of the file list, the `Diff Against` selection can be |
| 368 | changed. This selection allows one to choose if the currently viewed |
| 369 | patch set should be compared against its base or against another patch |
| 370 | set of this change. The file list is updated accordingly. |
| 371 | |
| 372 | The file list header also provides an `Open All` button that opens the |
| 373 | diff views for all files in the file list. |
| 374 | |
| 375 | image::images/user-review-ui-change-screen-file-list-header.png[width=800, link="images/user-review-ui-change-screen-file-list-header.png"] |
| 376 | |
| Edwin Kempin | b2a8ae3 | 2014-05-02 15:03:22 +0200 | [diff] [blame^] | 377 | [[patch-sets]] |
| 378 | === Patch Sets |
| 379 | |
| 380 | The change screen only presents one patch set at a time. Which patch |
| 381 | set is currently viewed can be seen from the `Patch Sets` drop-down |
| 382 | panel in the change header. It shows the number of the currently viewed |
| 383 | patch set and the total number of patch sets, in the form: "current |
| 384 | patch set/number of patch sets". |
| 385 | |
| 386 | If a non-current patch set is viewed this is indicated by the |
| 387 | link:#not-current[Not Current] change state. Please note that some |
| 388 | operations are only available on the current patch set. |
| 389 | |
| 390 | image::images/user-review-ui-change-screen-patch-sets.png[width=800, link="images/user-review-ui-change-screen-patch-sets.png"] |
| 391 | |
| 392 | The patch set drop-down list shows the list of patch sets and allows to |
| 393 | switch between them. The patch sets are sorted in descending order so |
| 394 | that the current patch set is always on top. |
| 395 | |
| 396 | Patch sets that have unpublished draft comments are marked by a comment |
| 397 | icon. |
| 398 | |
| 399 | Draft patch sets are marked with `DRAFT`. |
| 400 | |
| 401 | image::images/user-review-ui-change-screen-patch-set-list.png[width=800, link="images/user-review-ui-change-screen-patch-set-list.png"] |
| 402 | |
| Edwin Kempin | ae57e18 | 2014-04-30 13:38:55 +0200 | [diff] [blame] | 403 | [[old-change-screen]] |
| 404 | === Old Change Screen |
| 405 | |
| 406 | In addition to the normal change screen, this Gerrit version still |
| 407 | includes the old change screen that was used in earlier Gerrit |
| 408 | versions. Users that want to continue using the old change screen can |
| 409 | configure it in their preferences under |
| 410 | `Settings` > `Preferences` > `Change View`: |
| 411 | |
| 412 | image::images/user-review-ui-change-view-preference.png[width=800, link="images/user-review-ui-change-view-preference.png"] |
| 413 | |
| 414 | [WARNING] |
| 415 | The old change screen will be removed in a later version of Gerrit. |
| 416 | |
| Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 417 | GERRIT |
| 418 | ------ |
| 419 | Part of link:index.html[Gerrit Code Review] |
| 420 | |
| 421 | SEARCHBOX |
| 422 | --------- |